Do not hide SPA page while JS is loading #1929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
approved these changes
Apr 27, 2025
|
Seems like this change broke down several SPA-related tests. |
Should improve "visual" loads times, and SEO. Hiding the page is currently unnecessary it was added back in 2015 (9c11159), because we used to rely on the URL path fragment (`#/something`), which could be different from the page which was currently being loaded.
...but, we can replace it with `if: true`, which does not have the unwanted effect of hiding the content before everything loads. The reson is that ko.bindingContext/updateContext is pureComputed and won't update $data right after we replace the viewModel. We need someone to call `context[contextSubscribable]` to update it. Any binding will do that, but only after it's initialized, so the initialization will fail on "Property X was not defined". The pureComputed was introduced in knockout/knockout@0ac7010. It's probably not a knockout bug, as it's not possible to reproduce without our hacks with applyBindings in restoreUpdatedControls. If we used a binding handler for this, everything would be fine.
exyi
force-pushed
the
spa-dont-hide-page-before-js-loads
branch
from
05ba373 to
a7f4b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve "visual" loads times, and SEO.
Hiding the page is currently unnecessary
it was added back in 2015 (9c11159), because we used to rely on the URL path fragment (
#/something), which could be different from the page which was currently being loaded.